Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused method SimulationState.with_qubits #5748

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Remove unused method SimulationState.with_qubits #5748

merged 1 commit into from
Jul 13, 2022

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jul 13, 2022 •
edited
Loading

Avoid contradictory use of the constructor state argument,
which is required for the SimulationState base class,
but unknown to its derived classes.

Closes #5721

@pavoljuhas
Remove unused method SimulationState.with_qubits
8b7dcc3 
Avoid constructor argument conundrum detailed in quantumlib#5721.

Closes quantumlib#5721
@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners July 13, 2022 03:32
@pavoljuhas pavoljuhas requested a review from maffoo July 13, 2022 03:32
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jul 13, 2022
@pavoljuhas pavoljuhas mentioned this pull request Jul 13, 2022
Closed
@95-martin-orion 95-martin-orion added the BREAKING CHANGE For pull requests that are important to mention in release notes. label Jul 13, 2022
95-martin-orion
95-martin-orion approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added BREAKING_CHANGE label for completeness. LGTM

@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 13, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 13, 2022
@CirqBot CirqBot merged commit df782ff into quantumlib:master Jul 13, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 13, 2022
@pavoljuhas pavoljuhas deleted the remove-SimulationState.with_qubits branch July 13, 2022 16:35
@daxfohl daxfohl mentioned this pull request Mar 24, 2023
Closed
7 tasks
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@pavoljuhas @rht
Remove unused method SimulationState.with_qubits (quantumlib#5748)
8541137 
Avoid contradictory use of the constructor `state` argument,
which is required for the SimulationState base class,
but unknown to its derived classes.

Closes quantumlib#5721
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@pavoljuhas
Remove unused method SimulationState.with_qubits (quantumlib#5748)
331d009 
Avoid contradictory use of the constructor `state` argument,
which is required for the SimulationState base class,
but unknown to its derived classes.

Closes quantumlib#5721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
BREAKING CHANGE For pull requests that are important to mention in release notes. size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent use of state argument in SimulationState base and derived classes
3 participants
@pavoljuhas @95-martin-orion @CirqBot